Thread (201 messages) 201 messages, 7 authors, 2013-02-13

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

From: Ben Hutchings <hidden>
Date: 2012-12-30 12:42:46
Also in: lkml

On Sun, 2012-12-30 at 13:38 +0100, Ben Hutchings wrote:
On Sat, 2012-12-29 at 09:04 +0100, Andreas Hartmann wrote:
quoted
Ben Hutchings wrote:
quoted
3.2-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Andreas Hartmann <redacted>

commit be03d4a45c09ee5100d3aaaedd087f19bc20d01f upstream.
[...]

This patch is a workaround for

mac80211: retry sending failed BAR frames later instead of tearing down
aggr (http://www.spinics.net/lists/linux-wireless/msg76379.html -
f0425beda4d404a6e751439b562100b902ba9c98)
See:
http://thread.gmane.org/gmane.linux.kernel.wireless.general/83297/focus=83304


Meanwhile there was a bug report complaining about problems with
be03d4a45 when used as STA:
http://thread.gmane.org/gmane.linux.drivers.rt2x00.user/1257
You can find there a few other workaround proposals.
[...]

OK, I'll drop this for now.  Once this is sorted out, please send to
stable a complete list of fixes that are needed.
To be clear, I have all of these in the queue:

be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails
5b632fe85ec8 mac80211: introduce IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL
ab9d6e4ffe19 Revert: "rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails"

and I'm intending to drop/defer them all.

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program than vice versa.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help