Thread (201 messages) 201 messages, 7 authors, 2013-02-13

Re: [ 016/173] use clamp_t in UNAME26 fix

From: Ben Hutchings <hidden>
Date: 2012-12-29 11:01:41
Also in: lkml

On Sat, 2012-12-29 at 00:07 -0800, Jonathan Nieder wrote:
Ben Hutchings wrote:
quoted
The min/max call needed to have explicit types on some architectures
(e.g. mn10300). Use clamp_t instead to avoid the warning:

  kernel/sys.c: In function 'override_release':
  kernel/sys.c:1287:10: warning: comparison of distinct pointer types lacks a cast [enabled by default]

Reported-by: Fengguang Wu <redacted>
[...]
quoted
-		copy = min(sizeof(buf), max_t(size_t, 1, len));
I don't understand how this happens given that v2.6.36-rc1~68
(MN10300: Fix size_t and ssize_t, 2010-08-12) was supposed to fix this
kind of thing.
[...]

Neither do I, but I'm including it now just to be consistent with other
stable series.

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program than vice versa.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help