Thread (201 messages) 201 messages, 7 authors, 2013-02-13

[ 022/173] scsi: aha152x: Fix sparse warning and make printing pointer address more portable.

From: Ben Hutchings <hidden>
Date: 2012-12-28 19:21:38
Also in: lkml
Subsystem: aha152x scsi driver, scsi subsystem, the rest · Maintainers: "Juergen E. Fischer", "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds

3.2-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Krzysztof Wilczynski <redacted>

commit b631cf1f899f9d2e449884dbccc34940637c639f upstream.

This is to change use of "0x%08x" in favour of "%p" as per ../Documentation/printk-formats.txt,
which also takes care about the following warning during compilation time:

  drivers/scsi/aha152x.c: In function ���get_command���:
  drivers/scsi/aha152x.c:2987: warning: cast from pointer to integer of different size

Signed-off-by: Krzysztof Wilczynski <redacted>
Signed-off-by: Jiri Kosina <redacted>
Signed-off-by: Ben Hutchings <redacted>
---
 drivers/scsi/aha152x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index 19a3694..dd4547b 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -2984,8 +2984,8 @@ static int get_command(char *pos, Scsi_Cmnd * ptr)
 	char *start = pos;
 	int i;
 
-	SPRINTF("0x%08x: target=%d; lun=%d; cmnd=( ",
-		(unsigned int) ptr, ptr->device->id, ptr->device->lun);
+	SPRINTF("%p: target=%d; lun=%d; cmnd=( ",
+		ptr, ptr->device->id, ptr->device->lun);
 
 	for (i = 0; i < COMMAND_SIZE(ptr->cmnd[0]); i++)
 		SPRINTF("0x%02x ", ptr->cmnd[i]);

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help