Thread (201 messages) 201 messages, 7 authors, 2013-02-13

[ 166/173] udf: fix memory leak while allocating blocks during write

From: Ben Hutchings <hidden>
Date: 2012-12-28 19:17:23
Also in: lkml

3.2-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Namjae Jeon <redacted>

commit 2fb7d99d0de3fd8ae869f35ab682581d8455887a upstream.

Need to brelse the buffer_head stored in cur_epos and next_epos.

Signed-off-by: Namjae Jeon <redacted>
Signed-off-by: Ashish Sangwan <redacted>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ben Hutchings <redacted>
---
 fs/udf/inode.c |    4 ++++
 1 file changed, 4 insertions(+)
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -744,6 +744,8 @@ static struct buffer_head *inode_getblk(
 				goal, err);
 		if (!newblocknum) {
 			brelse(prev_epos.bh);
+			brelse(cur_epos.bh);
+			brelse(next_epos.bh);
 			*err = -ENOSPC;
 			return NULL;
 		}
@@ -774,6 +776,8 @@ static struct buffer_head *inode_getblk(
 	udf_update_extents(inode, laarr, startnum, endnum, &prev_epos);
 
 	brelse(prev_epos.bh);
+	brelse(cur_epos.bh);
+	brelse(next_epos.bh);
 
 	newblock = udf_get_pblock(inode->i_sb, newblocknum,
 				iinfo->i_location.partitionReferenceNum, 0);

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help