Re: [PATCH v5 06/18] clk: mediatek: Add MT8189 vlpcfg clock support
From: David Lechner <dlechner@baylibre.com>
Date: 2026-02-19 18:40:37
Also in:
linux-arm-kernel, linux-clk, linux-devicetree, linux-mediatek, lkml
On 2/2/26 12:28 AM, irving.ch.lin wrote:
From: Irving-CH Lin <redacted> Add support for the MT8189 vlpcfg clock controller, which provides clock gate control for vlp domain IPs. Signed-off-by: Irving-CH Lin <redacted> ---
...
+static const struct of_device_id of_match_clk_mt8189_vlpcfg[] = {
+ { .compatible = "mediatek,mt8189-vlp-ao", .data = &vlpcfg_ao_reg_mcd },
+ { .compatible = "mediatek,mt8189-vlpcfg-ao", .data = &vlpcfg_reg_mcd },
These names are a bit confusing to me. I would expect vlpcfg_ao_reg_mcd
to match "mediatek,mt8189-vlpcfg-ao" since they both contain "vlpcfg" and
"ao" in the name.
In other words, this is the naming I would expect to avoid confusion:
{ .compatible = "mediatek,mt8189-vlp-ao", .data = &vlp_ao_reg_mcd },
{ .compatible = "mediatek,mt8189-vlpcfg-ao", .data = &vlpcfg_ao_reg_mcd },
I suspect that the same improvement could be made in the other patches in
this series as well.
+ { /* sentinel */ }
+};
+