Re: [PATCH 0/5] Add support for the IPQ5018 Internal GE PHY

From
Andrew Lunn <andrew@lunn.ch>
Date
2025-05-28 12:00:27
Also in
linux-arm-msm, linux-clk, linux-devicetree, lkml
Reply to
George Moussalem, 2025-05-28
quoted
arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: ethernet-phy@7: clocks: [[7, 36], [7, 37]] is too long
	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: ethernet-phy@7: clocks: [[7, 36], [7, 37]] is too long
	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
These pop up as the phy needs to enable 2 clocks (RX and TX) during probe
which conflicts with the restriction set in ethernet-phy.yaml which says:

  clocks:
    maxItems: 1

Would you like me to add a condition in qca,ar803x.yaml on the compatible
(PHY ID) to override it and set it to two?

Likewise on resets, right now we I've got 1 reset (a bitmask that actually
triggers 4 resets) to conform to the bindings. If, as per ongoing
discussion, I need to list all resets, it will also conflict with the
restriction on resets of max 1 item.
You should describe the hardware. If the hardware has more than one
reset or clock, describe them all, and please fixup the binding to
suit.

	Andrew
Thread (34 messages) 34 messages, 6 authors, last reply 2025-05-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help