Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2025-05-26 04:17:37
Also in
linux-arm-msm, linux-clk, linux-devicetree, lkml
Reply to
George Moussalem via B4 Relay, 2025-05-25
On 25/05/2025 19:56, George Moussalem via B4 Relay wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/qca,ar803x.yaml b/Documentation/devicetree/bindings/net/qca,ar803x.yaml
index 3acd09f0da863137f8a05e435a1fd28a536c2acd..a9e94666ff0af107db4f358b144bf8644c6597e8 100644
--- a/Documentation/devicetree/bindings/net/qca,ar803x.yaml
+++ b/Documentation/devicetree/bindings/net/qca,ar803x.yaml
@@ -60,6 +60,29 @@ properties:
     minimum: 1
     maximum: 255
 
+  qca,dac:
+    description:
+      Values for MDAC and EDAC to adjust amplitude, bias current settings,
+      and error detection and correction algorithm. Only set in a PHY to PHY
+      link architecture to accommodate for short cable length.
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    items:
+      - items:
+          - description: value for MDAC. Expected 0x10, if set
+          - description: value for EDAC. Expected 0x10, if set
If this is fixed to 0x10, then this is fully deducible from compatible.
Drop entire property.
quoted hunk ↗ jump to hunk
+      - maxItems: 1
+
+  qca,eth-ldo-enable:
qcom,tcsr-syscon to match property already used.
quoted hunk ↗ jump to hunk
+    description:
+      Register in TCSR to enable the LDO controller to supply
+      low voltages to the common ethernet block (CMN BLK).
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    items:
+      - items:
+          - description: phandle of TCSR syscon
+          - description: offset of TCSR register to enable the LDO controller
+      - maxItems: 1
You listed two items, but second is just one item? Drop.

Best regards,
Krzysztof
Thread (34 messages) 34 messages, 6 authors, last reply 2025-05-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help