Re: [PATCH 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support

From
George Moussalem <hidden>
Date
2025-05-26 04:29:13
Also in
linux-arm-msm, linux-clk, linux-devicetree, lkml
Reply to
Andrew Lunn, 2025-05-25
Hi Andrew,

On 5/25/25 23:42, Andrew Lunn wrote:
quoted
+	phy_write_mmd(phydev, MDIO_MMD_PCS, IPQ5018_PHY_MMD3_AZ_CTRL1,
+		      IPQ5018_PHY_MMD3_AZ_CTRL1_VAL);
Using MMD3 in the name is a good idea, but PCS would be better. Not
everybody knows MDIO_MMD_PCS == 3.
Will rename all IPQ5018_PHY_MMD3* macros to IPQ5018_PHY_PCS* in next version.
	
     Andrew

---
pw-bot: cr
Thanks,
George
Thread (34 messages) 34 messages, 6 authors, last reply 2025-05-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help