Re: [PATCH 5/5] arm64: dts: qcom: ipq5018: Add GE PHY to internal mdio bus

From
George Moussalem <hidden>
Date
2025-05-27 13:37:10
Also in
linux-arm-msm, linux-clk, linux-devicetree, lkml
Reply to
Konrad Dybcio, 2025-05-27

On 5/27/25 17:34, Konrad Dybcio wrote:
On 5/25/25 7:56 PM, George Moussalem via B4 Relay wrote:
quoted
From: George Moussalem <redacted>

The IPQ5018 SoC contains an internal GE PHY, always at phy address 7.
As such, let's add the GE PHY node to the SoC dtsi.

In addition, the GE PHY outputs both the RX and TX clocks to the GCC
which gate controls them and routes them back to the PHY itself.
So let's create two DT fixed clocks and register them in the GCC node.

Signed-off-by: George Moussalem <redacted>
---
  arch/arm64/boot/dts/qcom/ipq5018.dtsi | 27 +++++++++++++++++++++++++--
  1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index 03ebc3e305b267c98a034c41ce47a39269afce75..ff2de44f9b85993fb2d426f85676f7d54c5cf637 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -16,6 +16,18 @@ / {
  	#size-cells = <2>;
  
  	clocks {
+		gephy_rx_clk: gephy-rx-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <125000000>;
+			#clock-cells = <0>;
+		};
+
+		gephy_tx_clk: gephy-tx-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <125000000>;
+			#clock-cells = <0>;
+		};
+
  		sleep_clk: sleep-clk {
  			compatible = "fixed-clock";
  			#clock-cells = <0>;
@@ -192,6 +204,17 @@ mdio0: mdio@88000 {
  			clock-names = "gcc_mdio_ahb_clk";
  
  			status = "disabled";
+
+			ge_phy: ethernet-phy@7 {
drop the label unless it needs to be passed somewhere
it is needed for boards where the qcom,dac-preset-short-cable property needs to be set. Thanks for the quick review!
Reviewed-by: Konrad Dybcio <redacted>

Konrad
George
Thread (34 messages) 34 messages, 6 authors, last reply 2025-05-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help