Thread (50 messages) 50 messages, 10 authors, 2025-02-22

Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep

From: David Lechner <dlechner@baylibre.com>
Date: 2025-02-13 17:25:24
Also in: linux-gpio, linux-iio, linux-mmc, linux-phy, linux-sound, lkml

On 2/12/25 3:36 AM, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <redacted>


On Mon, 10 Feb 2025 16:33:26 -0600, David Lechner wrote:
quoted
This series was inspired by some minor annoyance I have experienced a
few times in recent reviews.

Calling gpiod_set_array_value_cansleep() can be quite verbose due to
having so many parameters. In most cases, we already have a struct
gpio_descs that contains the first 3 parameters so we end up with 3 (or
often even 6) pointer indirections at each call site. Also, people have
a tendency to want to hard-code the first argument instead of using
struct gpio_descs.ndescs, often without checking that ndescs >= the
hard-coded value.

[...]
Applied, thanks!

[06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep
        commit: eb2e9c308d2882d9d364af048eb3d8336d41c4bb

Best regards,
Hi Bartosz,

Do you plan to pick up the other patches that have been acked
as well? It seems like most folks were OK with everything going
though the gpio tree since the changes are small.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help