Thread (50 messages) 50 messages, 10 authors, 2025-02-22

Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep

From: Bartosz Golaszewski <hidden>
Date: 2025-02-12 09:36:27
Also in: linux-gpio, linux-iio, linux-mmc, linux-phy, linux-sound, lkml

From: Bartosz Golaszewski <redacted>


On Mon, 10 Feb 2025 16:33:26 -0600, David Lechner wrote:
This series was inspired by some minor annoyance I have experienced a
few times in recent reviews.

Calling gpiod_set_array_value_cansleep() can be quite verbose due to
having so many parameters. In most cases, we already have a struct
gpio_descs that contains the first 3 parameters so we end up with 3 (or
often even 6) pointer indirections at each call site. Also, people have
a tendency to want to hard-code the first argument instead of using
struct gpio_descs.ndescs, often without checking that ndescs >= the
hard-coded value.

[...]
Applied, thanks!

[01/15] gpiolib: add gpiod_multi_set_value_cansleep()
        commit: 91931af18bd22437e08e2471f5484d6fbdd8ab93

Best regards,
-- 
Bartosz Golaszewski [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help