Thread (50 messages) 50 messages, 10 authors, 2025-02-22

Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()

From: Andy Shevchenko <andy@kernel.org>
Date: 2025-02-11 09:41:14
Also in: linux-gpio, linux-iio, linux-mmc, linux-phy, linux-sound, lkml

On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote:
Use bitmap_get_value8() instead of accessing the bitmap directly.

Accessing the bitmap directly is not considered good practice. We now
have a helper function that can be used instead, so let's use it.
Thank you, LGTM (one minor thing you may address,
or keep it as in the current variant of the patch),

Reviewed-by: Andy Shevchenko <andy@kernel.org>

...
+#include <linux/bitmap.h>
 #include <linux/bitops.h>
bitmap.h implies bitops.h

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help