Thread (34 messages) 34 messages, 5 authors, 2024-08-27

Re: [PATCH v4 net-next 00/12] net: introduce TX H/W shaping API

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-08-27 13:53:06

On Tue, 27 Aug 2024 09:54:52 +0200 Paolo Abeni wrote:
quoted
For the case above we could technically identify the correct parent by
skipping the nodes which will be garbage collected later.   
I think that implementation would be quite non trivial/error prone, and 
I think making the new root's parent explicit would be more clear from 
user-space perspective.

What I have now in my local tree is a group() implementation the 
inherits the newly created root's parent handle from the leaves, if all 
of them have the same parent prior to the group() invocation. Otherwise 
it requires the user to specify the root's parent handle. In any case, 
the user-specified root's parent handle value overrides the 
'inherited'/guessed one.

It will cover the above and will not require an explicit parent in most 
case. Would that be good enough?
Yes, that's great.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help