On 8/23/24 10:35, Paolo Abeni wrote:

On 8/23/24 03:48, Jakub Kicinski wrote:

quoted

On Tue, 20 Aug 2024 17:12:23 +0200 Paolo Abeni wrote:

quoted

+    render-max: true
+    entries:
+      - name: unspec
+        doc: The scope is not specified.
+      -
+        name: netdev
+        doc: The main shaper for the given network device.
+      -
+        name: queue
+        doc: The shaper is attached to the given device queue.
+      -
+        name: node
+        doc: |
+             The shaper allows grouping of queues or others
+             node shapers, is not attached to any user-visible

Saying it's not attached is confusing. Makes it sound like it exists
outside of the scope of a struct net_device.

What about:

    Can be placed in any arbitrary location of
    the scheduling tree, except leaves and root.

To rephrase the whole doc:

	     The shaper allows grouping of queues or others
              node shapers; can be nested to either @netdev
              shapers or other @node shapers, allowing placement
              in any arbitrary location of the scheduling tree,
              except leaves and root.

/P