On 8/23/24 02:43, Jakub Kicinski wrote:

On Tue, 20 Aug 2024 17:12:21 +0200 Paolo Abeni wrote:

quoted

* Delegation

A containers wants to limit the aggregate B/W bandwidth of 2 of the 3
queues it owns - the starting configuration is the one from the
previous point:

SPEC=Documentation/netlink/specs/net_shaper.yaml
./tools/net/ynl/cli.py --spec $SPEC \
	--do group --json '{"ifindex":'$IFINDEX',
			"leaves": [
			  {"handle": {"scope": "queue", "id":'$QID1' },
			   "weight": '$W1'},
			  {"handle": {"scope": "queue", "id":'$QID2' },
			   "weight": '$W2'}],
			"root": { "handle": {"scope": "node"},
				  "parent": {"scope": "node", "id": 0},

In the delegation use case I was hoping "parent" would be automatic.

Currently the parent is automatic/implicit when creating a node directly 
nested to the the netdev shaper.

I now see we can use as default parent the current leaves' parent, when 
that is the same for all the to-be-grouped leaves.

Actually, if we restrict the group operation to operate only on set of 
leaves respecting the above, I *guess* we will not lose generality and 
we could simplify a bit the spec. WDYT?

Thanks,

Paolo