On 8/27/24 03:50, Jakub Kicinski wrote:

On Fri, 23 Aug 2024 10:35:05 +0200 Paolo Abeni wrote:

quoted

quoted

quoted

+        name: node
+        doc: |
+             The shaper allows grouping of queues or others
+             node shapers, is not attached to any user-visible

Saying it's not attached is confusing. Makes it sound like it exists
outside of the scope of a struct net_device.

What about:

    Can be placed in any arbitrary location of
    the scheduling tree, except leaves and root.

Oh, I was thinking along the same lines above.
Whether "except leaves or root" or "inner node" is clearer is up to you.

I agree "inner node" should be clear.

quoted

quoted

quoted

+      -
+        name: weight
+        type: u32
+        doc: |
+          Weighted round robin weight for given shaper.

Relative weight of the input into a round robin node.

I would avoid mentioning 'input' unless we rolls back to the previous
naming scheme.

Okay, how about:

	Relative weight used by a parent round robin node.

Fine by me.

quoted

quoted

quoted

+           Differently from @leaves and @shaper allow specifying
+           the shaper parent handle, too.

Maybe this attr is better called "node", after all.

Fine by me, but would that cause some confusion with the alias scope
value?

But to be clear, the "root" describes the node we're creating, right?

Yes. I guess the possible confusion I mentioned will not be so 
confusing, after all. I'll go with this option.

Thanks,

Paolo