Re: [PATCH v4 net-next 12/12] iavf: Add net_shaper_ops support
From: kernel test robot <hidden>
Date: 2024-08-20 23:04:02
Also in:
oe-kbuild-all
Hi Paolo, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Abeni/tools-ynl-lift-an-assumption-about-spec-file-name/20240820-231626 base: net-next/main patch link: https://lore.kernel.org/r/08cd87e754552c5f413ead220abdaf1ccfadf21c.1724165948.git.pabeni%40redhat.com patch subject: [PATCH v4 net-next 12/12] iavf: Add net_shaper_ops support config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240821/202408210617.aCdtdwAt-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240821/202408210617.aCdtdwAt-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202408210617.aCdtdwAt-lkp@intel.com/ (local) All warnings (new ones prefixed by >>):
quoted
drivers/net/ethernet/intel/iavf/iavf_main.c:4965: warning: Function parameter or struct member 'handle' not described in 'iavf_shaper_set'
vim +4965 drivers/net/ethernet/intel/iavf/iavf_main.c 4948 4949 /** 4950 * iavf_shaper_set - check that shaper info received 4951 * @dev: pointer to netdev 4952 * @shaper: configuration of shaper. 4953 * @extack: Netlink extended ACK for reporting errors 4954 * 4955 * Returns: 4956 * * %0 - Success 4957 * * %-EOPNOTSUPP - Driver doesn't support this scope. 4958 * * %-EINVAL - Invalid queue number in input 4959 **/ 4960 static int 4961 iavf_shaper_set(struct net_device *dev, 4962 const struct net_shaper_handle *handle, 4963 const struct net_shaper_info *shaper, 4964 struct netlink_ext_ack *extack)
4965 { 4966 struct iavf_adapter *adapter = netdev_priv(dev);
4967 bool need_cfg_update = false;
4968 int ret = 0;
4969
4970 ret = iavf_verify_handle(dev, handle, extack);
4971 if (ret)
4972 return ret;
4973
4974 if (handle->scope == NET_SHAPER_SCOPE_QUEUE) {
4975 struct iavf_ring *tx_ring = &adapter->tx_rings[handle->id];
4976
4977 tx_ring->q_shaper.bw_min = div_u64(shaper->bw_min, 1000);
4978 tx_ring->q_shaper.bw_max = div_u64(shaper->bw_max, 1000);
4979 tx_ring->q_shaper_update = true;
4980 need_cfg_update = true;
4981 }
4982
4983 if (need_cfg_update)
4984 adapter->aq_required |= IAVF_FLAG_AQ_CONFIGURE_QUEUES_BW;
4985
4986 return 0;
4987 }
4988
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki