On 12/14/23 09:13, Romain Gantois wrote:
Hello Russell,
On Thu, 10 Aug 2023, Russell King (Oracle) wrote:
quoted
quoted
We've had these issues before with stmmac, so this "stmmac needs the
PHY receive clock" is nothing new - it's had problems with system
suspend/resume in the past, and I've made suggestions... and when
there's been two people trying to work on it, I've attempted to get
them to talk to each other which resulted in nothing further
happening.
Another solution could possibly be that we reserve bit 30 on the
PHY dev_flags to indicate that the receive clock must always be
provided. I suspect that would have an advantage in another
...
Something like this for starters:
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
...
I've implemented and tested the general-case solution you proposed to this
receive clock issue with stmmac drivers. The core of your suggestion is pretty
much unchanged, I just added a phylink_pcs flag for standalone PCS drivers that
also need to provide the receive clock.
I'd like to send a series for this upstream, which would allow solving this
issue for both the DWMAC RZN1 case and the AT803x PHY suspend/hibernate case
(and also potentially other cases with a similar bug).
I wanted to ask you how you would prefer to be credited in my patch series. I
was considering putting you as author and first signer of the initial patch
adding the phy_dev flag. Would that be okay or would you prefer something else?
Credit it whichever way you see fit, don't worry, better focus on the fix. I can test the result on MX8MM/MX8MP, so feel free to CC me on that.