Re: [PATCH] net: phy: at803x: Improve hibernation support on start up

From
Russell King (Oracle) <linux@armlinux.org.uk>
Date
2023-08-10 09:09:15
Also in
linux-clk
Reply to
Wei Fang, 2023-08-10
On Thu, Aug 10, 2023 at 03:28:13AM +0000, Wei Fang wrote:
quoted
quoted
Furthermore,
we would expect the hibernation mode is enabled when the ethernet
interface is brought up but the cable is not plugged, that is to say,
we only need the PHY to provide the clock for a while to make the MAC
reset successfully.

Means, if external clock is not provided, MAC is not fully functional.
Correct?
The MAC will failed to do software reset if the PHY input clocks are not
present.
Yes, that's well known to me - it's been brought up before with stmmac
and phylink. I said earlier in this thread about this.
quoted
For example, if stmmac_open() fails without external clock, will
stmmac_release() work properly?
Actually, I don't know much about stmmac driver and the dwmac IP,
Because I'm not responsible for this IP on NXP i.MX platform. But I
have a look at the code of stmmac_release(), I think stmmac_release()
will work properly, because it invokes phylink_stop() and phylink_disconnect_phy()
first which will disable the clock from PHY.
When tearing down a network device, there should be no reason to call
phylink_stop() - unregistering the netdev will take the network device
down, and thus call the .ndo_stop method if the device was up. .ndo_stop
should already be calling phylink_stop().

I just don't get why driver authors don't check things like this...

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Thread (32 messages) 32 messages, 6 authors, last reply 2023-12-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help