Re: [PATCH] net: phy: at803x: Improve hibernation support on start up

From
Oleksij Rempel <o.rempel@pengutronix.de>
Date
2023-08-10 04:32:59
Reply to
Marek Vasut, 2023-08-10
On Thu, Aug 10, 2023 at 02:49:55AM +0200, Marek Vasut wrote:
On 8/10/23 00:06, Andrew Lunn wrote:
quoted
On Wed, Aug 09, 2023 at 11:34:19PM +0200, Marek Vasut wrote:
quoted
On 8/9/23 15:40, Andrew Lunn wrote:
quoted
quoted
quoted
Hm.. how about officially defining this PHY as the clock provider and disable
PHY automatic hibernation as long as clock is acquired?
Sorry, I don't know much about the clock provider/consumer, but I think there
will be more changes if we use clock provider/consume mechanism.
Less changes is not always best. What happens when a different PHY is
used?
Then the system wouldn't be affected by this AR803x specific behavior.
Do you know it really is specific to the AR803x? Turning the clock off
seams a reasonable thing to do when saving power, or when there is no
link partner.
This hibernation behavior seem specific to this PHY, I haven't seen it on
another PHY connected to the EQoS so far.
Hm.. if I see it correctly I have right now kind of similar issues with
Microchip KSZ9893 switch attached to EQoS. The switch is clock
provider and I need to make sure that switch has CPU port enabled before
probing the ethernet controller.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Thread (32 messages) 32 messages, 6 authors, last reply 2023-12-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help