Thread (52 messages) 52 messages, 6 authors, 2024-01-08

Re: [PATCH v8 14/14] dt-bindings: net: ar803x: add qca8084 PHY properties

flat view

From: Jie Luo <hidden>
Date: 2023-12-15 10:17:41
Also in: linux-devicetree, linux-doc, lkml


On 12/15/2023 4:22 PM, Krzysztof Kozlowski wrote:
On 15/12/2023 08:40, Luo Jie wrote:
quoted
The following properties are added for qca8084 PHY.

1. add the compatible string "ethernet-phy-id004d.d180" since
    the PHY device is not accessible during MDIO bus register.
2. add property "qcom,phy-addr-fixup" for customizing MDIO address.
3. add property "qcom,phy-work-mode" for specifying qca8084 PHY
    work mode.
4. add the initial clocks and resets.
All my previous comments (sent one minute before this patchset :) )
apply. Please respond to them or implement them in v5 (not earlier than
after 24h).


Best regards,
Krzysztof
Sure, will update the new version after the discussion completed.
actually i have query about the dt-bindings doc.

The "maxItems: 1" of the property resets is defined in ethernet-phy.yaml
that is referenced by qca,ar803x.yaml, but i have 11 reset instances
used for qca8084 PHY, it seems i can't overwrite maxItems of reset
property to 11 from 1 in qca,ar803x.yaml.

is there any method to overwrite the maxItems value?

Thanks,
Jie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help