On Mon, Nov 13, 2023 at 12:07 PM Alexander Sverdlin
[off-list ref] wrote:

On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote:

quoted

quoted

+       /* Issue the reboot */

            ^^^^^^^^^^^^^^^^^^^^^^
This is the relevant comment, one can extend it, but looks already quite
informative considering EP93XX_SYSCON_DEVCFG_SWRST register name.

This does not explain the necessity of the mdelay() below.

But Nikita would be able to include more verbose comment if
you'd have a suggestion.

Please,add one.

quoted

quoted

+       ep93xx_devcfg_set_clear(priv->map, EP93XX_SYSCON_DEVCFG_SWRST, 0x00);
+       ep93xx_devcfg_set_clear(priv->map, 0x00, EP93XX_SYSCON_DEVCFG_SWRST);

quoted

+       mdelay(1000);

Atomic?! Such a huge delay must be explained, esp. why it's atomic.

-- 
With Best Regards,
Andy Shevchenko