Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Date: 2023-11-11 18:19:19
Also in:
alsa-devel, dmaengine, linux-clk, linux-devicetree, linux-gpio, linux-ide, linux-input, linux-pm, linux-pwm, linux-rtc, linux-spi, linux-watchdog, lkml
Hi Andy, On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote:
quoted
+ /* Issue the reboot */ + ep93xx_devcfg_set_clear(priv->map, EP93XX_SYSCON_DEVCFG_SWRST, 0x00); + ep93xx_devcfg_set_clear(priv->map, 0x00, EP93XX_SYSCON_DEVCFG_SWRST);quoted
+ mdelay(1000);Atomic?! Such a huge delay must be explained, esp. why it's atomic.
atomic or not, SoC is supposed to reset itself here. However there is an errata [1] and the SoC can lockup instead. So even pr_emerg() makes sense to me.
quoted
+ pr_emerg("Unable to restart system\n"); + return NOTIFY_DONE;
[1] http://web.archive.org/web/20161130230727/http://www.cirrus.com/en/pubs/appNote/AN258REV2.pdf -- Alexander Sverdlin.