Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Date: 2023-11-13 10:04:50
Also in:
alsa-devel, dmaengine, linux-clk, linux-devicetree, linux-gpio, linux-ide, linux-input, linux-pm, linux-pwm, linux-rtc, linux-spi, linux-watchdog, lkml
Hi Andy! On Mon, 2023-11-13 at 11:59 +0200, Andy Shevchenko wrote:
On Sat, Nov 11, 2023 at 8:18 PM Alexander Sverdlin [off-list ref] wrote:quoted
On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote:...
[1]
quoted
quoted
quoted
+ mdelay(1000);Atomic?! Such a huge delay must be explained, esp. why it's atomic.atomic or not, SoC is supposed to reset itself here. However there is an errata [1] and the SoC can lockup instead.Good, and what I'm saying is that this piece of code must have a comment explaining this.
And it has, but for some reason you've trimmed it in your reply... -- Alexander Sverdlin.