Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset
From: Andy Shevchenko <andy@kernel.org>
Date: 2023-07-21 16:40:44
Also in:
alsa-devel, dmaengine, linux-clk, linux-devicetree, linux-gpio, linux-ide, linux-input, linux-pm, linux-pwm, linux-rtc, linux-spi, linux-watchdog, lkml
On Thu, Jul 20, 2023 at 02:29:14PM +0300, Nikita Shubin via B4 Relay wrote:
From: Nikita Shubin <nikita.shubin@maquefel.me> Implement the reset behaviour of the various EP93xx SoCS in drivers/power/reset. It used to be located in arch/arm/mach-ep93xx.
...
+// SPDX-License-Identifier: (GPL-2.0)
Are you sure this is correct form? Have you checked your patches? ...
+#include <linux/of_device.h>
Do you need this? Or maybe you need another (of*.h) one? ...
+ /* Issue the reboot */ + ep93xx_devcfg_set_clear(priv->map, EP93XX_SYSCON_DEVCFG_SWRST, 0x00); + ep93xx_devcfg_set_clear(priv->map, 0x00, EP93XX_SYSCON_DEVCFG_SWRST);
+ mdelay(1000);
Atomic?! Such a huge delay must be explained, esp. why it's atomic.
+ pr_emerg("Unable to restart system\n");
+ return NOTIFY_DONE;...
+ err = register_restart_handler(&priv->restart_handler); + if (err) + return dev_err_probe(dev, err, "can't register restart notifier\n");
+ return err;
return 0; -- With Best Regards, Andy Shevchenko