Re: [PATCH v3 06/42] dt-bindings: soc: Add Cirrus EP93xx
From: Krzysztof Kozlowski <hidden>
Date: 2023-07-21 14:04:50
Also in:
alsa-devel, dmaengine, linux-clk, linux-devicetree, linux-gpio, linux-ide, linux-input, linux-pm, linux-pwm, linux-rtc, linux-spi, linux-watchdog, lkml
On 20/07/2023 13:29, Nikita Shubin via B4 Relay wrote:
From: Nikita Shubin <nikita.shubin@maquefel.me> This adds device tree bindings for the Cirrus Logic EP93xx. Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- .../bindings/arm/cirrus/ep9301-syscon.yaml | 59 ++++++++++++++++++++++
syscon goes to soc directory. Also, please add vendor prefix to the filenames.
quoted hunk ↗ jump to hunk
.../devicetree/bindings/arm/cirrus/ep9301.yaml | 39 ++++++++++++++ 2 files changed, 98 insertions(+)diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml new file mode 100644 index 000000000000..77fbe1f006fd --- /dev/null +++ b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/cirrus/ep9301-syscon.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cirrus Logic EP93xx Platforms System Controller + +maintainers: + - Alexander Sverdlin <alexander.sverdlin@gmail.com> + - Nikita Shubin <nikita.shubin@maquefel.me> + +properties: + compatible: + oneOf: + - items: + - enum: + - cirrus,ep9302-syscon + - cirrus,ep9307-syscon + - cirrus,ep9312-syscon + - cirrus,ep9315-syscon + - const: cirrus,ep9301-syscon + - const: syscon + - const: simple-mfd + - items: + - const: cirrus,ep9301-syscon + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + reboot: + type: object + properties: + compatible: + const: cirrus,ep9301-reboot
Patch introducing it should be before this one. Also, do not use different styles for your child nodes. Your other nodes use $ref.
+ + clock-controller: + type: object + $ref: ../../clock/cirrus,ep9301-clk.yaml
Absolute path, so /schemas/clock/cirrus.....
+ + pinctrl: + type: object + $ref: ../../pinctrl/cirrus,ep9301-pinctrl.yaml
Ditto
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@80930000 {
+ compatible = "cirrus,ep9301-syscon",
+ "syscon", "simple-mfd";
+ reg = <0x80930000 0x1000>;Incomplete example.
quoted hunk ↗ jump to hunk
+ };diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml new file mode 100644 index 000000000000..6087784e93fb --- /dev/null
Best regards, Krzysztof