Le Fri, 18 Mar 2022 18:32:17 +0200,
Andy Shevchenko [off-list ref] a écrit :

On Fri, Mar 18, 2022 at 05:00:52PM +0100, Clément Léger wrote:

quoted

Add support to retrieve a i2c bus in sfp with a fwnode. This support
is using the fwnode API which also works with device-tree and ACPI.
For this purpose, the device-tree and ACPI code handling the i2c
adapter retrieval was factorized with the new code. This also allows
i2c devices using a software_node description to be used by sfp code.  

quoted

+		i2c = fwnode_find_i2c_adapter_by_node(np);  

Despite using this, I believe you may split this patch to at least two where
first one is preparatory (converting whatever parts is possible to fwnode
(looks like ACPI case may be optimized) followed by this change.

Indeed, I had hesitate to do so but is seems more correct not to mix
everything.

Thanks for the review.


-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com