Re: [PATCH 2/6] i2c: fwnode: add fwnode_find_i2c_adapter_by_node()
From: Clément Léger <clement.leger@bootlin.com>
Date: 2022-03-18 16:56:00
Also in:
linux-acpi, linux-i2c, lkml
From: Clément Léger <clement.leger@bootlin.com>
Date: 2022-03-18 16:56:00
Also in:
linux-acpi, linux-i2c, lkml
Le Fri, 18 Mar 2022 18:29:39 +0200, Andy Shevchenko [off-list ref] a écrit :
On Fri, Mar 18, 2022 at 05:00:48PM +0100, Clément Léger wrote:quoted
Add fwnode_find_i2c_adapter_by_node() which allows to retrieve a i2c adapter using a fwnode. Since dev_fwnode() uses the fwnode provided by the of_node member of the device, this will also work for devices were the of_node has been set and not the fwnode field.quoted
+ /* For ACPI device node, we do not want to match the parent */Why? Neither commit message nor this comment does not answer to this question.
Yes you are right. This is done to keep the existing behavior that is applied by i2c_acpi_find_adapter_by_handle() which only checks the device node and not the parent one. Using the same behavior than for DT would add some unwanted behavior in I2C device lookup for ACPI. -- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com