On 21/01/2022 16.35, Arend van Spriel wrote:

On 1/4/2022 8:26 AM, Hector Martin wrote:

quoted

@@ -96,6 +97,7 @@ static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = {
  	BRCMF_FW_ENTRY(BRCM_CC_4371_CHIP_ID, 0xFFFFFFFF, 4371),
  	BRCMF_FW_ENTRY(BRCM_CC_4377_CHIP_ID, 0xFFFFFFFF, 4377B3), /* 4 */
  	BRCMF_FW_ENTRY(BRCM_CC_4378_CHIP_ID, 0xFFFFFFFF, 4378B1), /* 3 */
+	BRCMF_FW_ENTRY(BRCM_CC_4387_CHIP_ID, 0xFFFFFFFF, 4387C2), /* 7 */

Regarding the revmask in this firmware mapping table my common practice 
was to disable older revisions and enable for given revision and newer 
until proven otherwise. So for the 4387c2 that would have to following 
mask 0xFFFFFF80 (if rev 7 indeed matches with c2).

Makes sense, I changed it to that for all the additions :)

-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub