Thread (117 messages) 117 messages, 5 authors, 2022-01-31

Re: [PATCH v2 23/35] brcmfmac: cfg80211: Add support for scan params v2

From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Date: 2022-01-04 19:46:41
Also in: linux-acpi, linux-devicetree, linux-wireless, lkml

On January 4, 2022 8:30:51 AM Hector Martin [off-list ref] wrote:
This new API version is required for at least the BCM4387 firmware. Add
support for it, with a fallback to the v1 API.

Acked-by: Linus Walleij <redacted>
Signed-off-by: Hector Martin <redacted>
---
.../broadcom/brcm80211/brcmfmac/cfg80211.c    | 113 ++++++++++++++----
.../broadcom/brcm80211/brcmfmac/feature.c     |   1 +
.../broadcom/brcm80211/brcmfmac/feature.h     |   4 +-
.../broadcom/brcm80211/brcmfmac/fwil_types.h  |  49 +++++++-
4 files changed, 145 insertions(+), 22 deletions(-)
Compiling this patch with C=2 gives following warnings:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: 
warning: incorrect type in assignment (different base types)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: 
expected restricted __le16 [usertype] version
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: got int
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: 
warning: incorrect type in assignment (different base types)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: 
expected restricted __le32 [usertype] scan_type
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: got int
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: 
warning: incorrect type in assignment (different base types)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: 
expected unsigned char [usertype] scan_type
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: got 
restricted __le32 [usertype] scan_type

Will check if this is a valid warning.

Regards,
Arend


Attachments

  • smime.p7s [application/pkcs7-signature] 4219 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help