On 1/4/2022 8:26 AM, Hector Martin wrote:

Apparently the hex passphrase mechanism does not work on newer
chips/firmware (e.g. BCM4387). It seems there was a simple way of
passing it in binary all along, so use that and avoid the hexification.

OpenBSD has been doing it like this from the beginning, so this should
work on all chips.

Also clear the structure before setting the PMK. This was leaking
uninitialized stack contents to the device.

Reviewed-by: Linus Walleij <redacted>

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Signed-off-by: Hector Martin <redacted>
---
  .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 13 +++++++------
  1 file changed, 7 insertions(+), 6 deletions(-)