Thread (117 messages) 117 messages, 5 authors, 2022-01-31

Re: [PATCH v2 12/35] brcmfmac: pcie: Fix crashes due to early IRQs

From: Andy Shevchenko <hidden>
Date: 2022-01-04 14:14:42
Also in: linux-acpi, linux-devicetree, linux-wireless, lkml

On Tue, Jan 4, 2022 at 9:29 AM Hector Martin [off-list ref] wrote:
The driver was enabling IRQs before the message processing was
initialized. This could cause IRQs to come in too early and crash the
driver. Instead, move the IRQ enable and hostready to a bus preinit
function, at which point everything is properly initialized.

Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.")
You should gather fixes at the beginning of the series, and even
possible to send them as a separate series. In the current state it's
unclear if there are dependencies on your new feature (must not be for
fixes that meant to be backported).

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help