Thread (117 messages) 117 messages, 5 authors, 2022-01-31

Re: [PATCH v2 12/35] brcmfmac: pcie: Fix crashes due to early IRQs

From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2022-01-10 07:20:17
Also in: linux-acpi, linux-devicetree, linux-wireless, lkml

On 1/4/2022 8:26 AM, Hector Martin wrote:
The driver was enabling IRQs before the message processing was
initialized. This could cause IRQs to come in too early and crash the
driver. Instead, move the IRQ enable and hostready to a bus preinit
function, at which point everything is properly initialized.

Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.")
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Reviewed-by: Linus Walleij <redacted>
Signed-off-by: Hector Martin <redacted>
---
  .../wireless/broadcom/brcm80211/brcmfmac/pcie.c  | 16 +++++++++++++---
  1 file changed, 13 insertions(+), 3 deletions(-)

Attachments

  • smime.p7s [application/pkcs7-signature] 4219 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help