On Thu, Dec 30, 2021 at 2:27 PM Andrew Lunn [off-list ref] wrote:

On Thu, Dec 30, 2021 at 12:54:07PM -0800, Dimitris Michailidis wrote:

quoted

On Thu, Dec 30, 2021 at 9:43 AM Jakub Kicinski [off-list ref] wrote:

quoted

On Thu, 30 Dec 2021 08:39:09 -0800 Dimitris Michailidis wrote:

quoted

Hook up the new driver to configuration and build.

Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>

New drivers must build cleanly with W=1 C=1. This one doesn't build at all:

drivers/net/ethernet/fungible/funeth/funeth.h:10:10: fatal error: fun_dev.h: No such file or directory
   10 | #include "fun_dev.h"
      |          ^~~~~~~~~~~

Hmm, I don't get this error. What I run is

make W=1 C=1 drivers/net/ethernet/fungible/

C=1 implies you need sparse installed. Do you?

I have sparse. Here's an example of what W=1 C=1 V=1 says is running:

  sparse -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise
-Wno-return-void -Wno-unknown-attribute  -D__x86_64__ --arch=x86
-mlittle-endian -m64
-Wp,-MMD,drivers/net/ethernet/fungible/funcore/.fun_dev.o.d  -nostdinc
-I./arch/x86/include -I./arch/x86/include/generated  -I./include
-I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi
-I./include/uapi -I./include/generated/uapi -include
./include/linux/compiler-version.h -include ./include/linux/kconfig.h
-include ./include/linux/compiler_types.h -D__KERNEL__
-fmacro-prefix-map=./= -DKBUILD_EXTRA_WARN1 -Wall -Wundef
-Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing
-fno-common -fshort-wchar -fno-PIE
-Werror=implicit-function-declaration -Werror=implicit-int
-Werror=return-type -Wno-format-security -std=gnu89 -mno-sse -mno-mmx
-mno-sse2 -mno-3dnow -mno-avx -fcf-protection=none -m64
-falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387
-mpreferred-stack-boundary=3 -mskip-rax-setup -mtune=generic
-mno-red-zone -mcmodel=kernel -DCONFIG_X86_X32_ABI -Wno-sign-compare
-fno-asynchronous-unwind-tables -mindirect-branch=thunk-extern
-mindirect-branch-register -fno-jump-tables
-fno-delete-null-pointer-checks -Wno-frame-address
-Wno-format-truncation -Wno-format-overflow
-Wno-address-of-packed-member -O2 --param=allow-store-data-races=0
-Wframe-larger-than=1024 -fstack-protector-strong
-Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable
-Wno-unused-const-variable -fno-omit-frame-pointer
-fno-optimize-sibling-calls -fno-stack-clash-protection -pg
-mrecord-mcount -mfentry -DCC_USING_FENTRY
-Wdeclaration-after-statement -Wvla -Wno-pointer-sign
-Wno-stringop-truncation -Wno-array-bounds -Wno-stringop-overflow
-Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than
-fno-strict-overflow -fno-stack-check -fconserve-stack
-Werror=date-time -Werror=incompatible-pointer-types
-Werror=designated-init -Wno-packed-not-aligned -Wextra -Wunused
-Wno-unused-parameter -Wmissing-declarations
-Wmissing-format-attribute -Wmissing-prototypes -Wold-style-definition
-Wmissing-include-dirs -Wunused-but-set-variable
-Wunused-const-variable -Wpacked-not-aligned -Wstringop-truncation
-Wno-missing-field-initializers -Wno-sign-compare -Wno-type-limits -g
-gdwarf-4  -DMODULE  -DKBUILD_BASENAME='"fun_dev"'
-DKBUILD_MODNAME='"funcore"' -D__KBUILD_MODNAME=kmod_funcore
drivers/net/ethernet/fungible/funcore/fun_dev.c

$ sparse --version
v0.6.4

    Andrew