On Thu, Dec 30, 2021 at 9:40 AM Andrew Lunn [off-list ref] wrote:

quoted

+static int msg_enable;
+module_param(msg_enable, int, 0644);
+MODULE_PARM_DESC(msg_enable, "bitmap of NETIF_MSG_* enables");
+

Module params are not liked. Please implement the ethtool op, if you
have not already done so.

The associated ethtool op is implemented. I think this module param is
fairly common
to control messages during probe and generally before the ethtool path
is available.

     Andrew