Re: [PATCH net-next 4/8] net/funeth: ethtool operations

From
Jakub Kicinski <kuba@kernel.org>
Date
2021-12-30 20:22:33
Reply to
Andrew Lunn, 2021-12-30
On Thu, 30 Dec 2021 19:04:08 +0100 Andrew Lunn wrote:
quoted
+static void fun_get_drvinfo(struct net_device *netdev,
+			    struct ethtool_drvinfo *info)
+{
+	const struct funeth_priv *fp = netdev_priv(netdev);
+
+	strscpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
+	strcpy(info->fw_version, "N/A");  
Don't set it, if you have nothing useful to put in it.
Also, if user has no way of reading the firmware version how do they
know when to update the FW in the flash? FW flashing seems pointless
without knowing the current FW version.
Thread (38 messages) 38 messages, 4 authors, last reply 2022-01-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help