On Thu, 30 Dec 2021 19:04:08 +0100 Andrew Lunn wrote:

quoted

+static void fun_get_drvinfo(struct net_device *netdev,
+			    struct ethtool_drvinfo *info)
+{
+	const struct funeth_priv *fp = netdev_priv(netdev);
+
+	strscpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
+	strcpy(info->fw_version, "N/A");  

Don't set it, if you have nothing useful to put in it.

Also, if user has no way of reading the firmware version how do they
know when to update the FW in the flash? FW flashing seems pointless
without knowing the current FW version.