Re: [PATCH net-next 4/8] net/funeth: ethtool operations

On Thu, Dec 30, 2021 at 12:28 PM Jakub Kicinski [off-list ref] wrote:

On Thu, 30 Dec 2021 08:39:05 -0800 Dimitris Michailidis wrote:

quoted

+static const char mac_rx_stat_names[][ETH_GSTRING_LEN] = {
+     "mac_rx_octets_total",
+     "mac_rx_octets_ok",
+     "mac_rx_frames_total",
+     "mac_rx_frames_ok",
+     "mac_rx_VLAN_frames_ok",
+     "mac_rx_unicast_frames",
+     "mac_rx_multicast_frames",
+     "mac_rx_broadcast_frames",
+     "mac_rx_frames_64",
+     "mac_rx_frames_65_127",
+     "mac_rx_frames_128_255",
+     "mac_rx_frames_256_511",
+     "mac_rx_frames_512_1023",
+     "mac_rx_frames_1024_1518",
+     "mac_rx_frames_1519_max",
+     "mac_rx_drop_events",
+     "mac_rx_errors",
+     "mac_rx_FCS_errors",
+     "mac_rx_alignment_errors",
+     "mac_rx_frame_too_long_errors",
+     "mac_rx_in_range_length_errors",
+     "mac_rx_undersize_frames",
+     "mac_rx_oversize_frames",
+     "mac_rx_jabbers",
+     "mac_rx_fragments",
+     "mac_rx_control_frames",
+     "mac_rx_pause",

quoted

+     "mac_rx_CBFCPAUSE15",
+     "mac_fec_correctable_errors",
+     "mac_fec_uncorrectable_errors",

Please drop all the stats which are reported via the structured API.
It's a new driver, users are better off using the standard API than
grepping for yet another unique, driver-specific string.

Will do.