Re: [PATCH net-next 3/8] net/funeth: probing and netdev ops

On Thu, Dec 30, 2021 at 10:33:03AM -0800, Dimitris Michailidis wrote:

On Thu, Dec 30, 2021 at 9:40 AM Andrew Lunn [off-list ref] wrote:

quoted

quoted

+static int msg_enable;
+module_param(msg_enable, int, 0644);
+MODULE_PARM_DESC(msg_enable, "bitmap of NETIF_MSG_* enables");
+

Module params are not liked. Please implement the ethtool op, if you
have not already done so.

The associated ethtool op is implemented. I think this module param is
fairly common
to control messages during probe and generally before the ethtool path
is available.

It is common in order drivers, but in general new drivers don't have
module parameters at all. Anybody debugging code before ethtool is
available from user space is probably also capable of recompiling the
driver to change the default value.

       Andrew