Re: [RFC net-next PATCH 06/16] net: phylink: Add function for optionally adding a PCS
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-10-05 09:51:43
Also in:
lkml
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-10-05 09:51:43
Also in:
lkml
On Mon, Oct 04, 2021 at 03:15:17PM -0400, Sean Anderson wrote:
This adds a function to set the PCS only if there is not one currently set. The intention here is to allow MAC drivers to have a "default" PCS (such as an internal one) which may be used when one has not been set via the device tree. This allows for backwards compatibility for cases where a PCS was automatically attached if necessary.
I'm not sure I entirely like this approach. Why can't the network driver check for the pcs-handle property and avoid using its "default" if present? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!