Re: [RFC net-next PATCH 08/16] net: macb: Clean up macb_validate
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-10-04 23:04:30
Also in:
lkml
On Mon, Oct 04, 2021 at 03:15:19PM -0400, Sean Anderson wrote:
As the number of interfaces grows, the number of if statements grows ever more unweildy. Clean everything up a bit by using a switch statement. No functional change intended.
This doesn't look right to me.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index e2730b3e1a57..18afa544b623 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c@@ -510,32 +510,55 @@ static void macb_validate(struct phylink_config *config, unsigned long *supported, struct phylink_link_state *state) { + bool one = state->interface == PHY_INTERFACE_MODE_NA;
Shouldn't this be != ? Since PHY_INTERFACE_MODE_NA is supposed to return all capabilities. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!