Re: [RFC net-next PATCH 03/16] net: sfp: Fix typo in state machine debug string

From
Andrew Lunn <andrew@lunn.ch>
Date
2021-10-04 21:31:29
Also in
lkml
Reply to
Sean Anderson, 2021-10-04
On Mon, Oct 04, 2021 at 03:15:14PM -0400, Sean Anderson wrote:
quoted hunk ↗ jump to hunk
The string should be "tx_disable" to match the state enum.

Signed-off-by: Sean Anderson <redacted>
---

 drivers/net/phy/sfp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 34e90216bd2c..ab77a9f439ef 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -134,7 +134,7 @@ static const char * const sm_state_strings[] = {
 	[SFP_S_LINK_UP] = "link_up",
 	[SFP_S_TX_FAULT] = "tx_fault",
 	[SFP_S_REINIT] = "reinit",
-	[SFP_S_TX_DISABLE] = "rx_disable",
+	[SFP_S_TX_DISABLE] = "tx_disable",
 };
Hi Sean

This is a bug fix. Please separate it out and base it on net, not
net-next.

Fixes: 4005a7cb4f55 ("net: phy: sftp: print debug message with text, not numbers")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Thread (59 messages) 59 messages, 5 authors, last reply 2021-10-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help