Hi Sergei,

Thanks for the review.

Subject: Re: [RFC/PATCH 04/18] ravb: Enable aligned_tx and tx_counters for
RZ/G2L

On 9/23/21 5:07 PM, Biju Das wrote:

   Somehow this patch haven't reached my OMP email -- I got it only thru
the linux-renesas-soc list... :-/

quoted

RZ/G2L need 4byte address alignment like R-Car Gen2 and it has
tx_counters like R-Car Gen3. This patch enable these features for
RZ/G2L.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/net/ethernet/renesas/ravb.h      | 2 +-
 drivers/net/ethernet/renesas/ravb_main.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/renesas/ravb.h

b/drivers/net/ethernet/renesas/ravb.h
index bee05e6fb815..bb92469d770e 100644

--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h

@@ -195,7 +195,7 @@ enum ravb_reg {
 	GECMR	= 0x05b0,
 	MAHR	= 0x05c0,
 	MALR	= 0x05c8,
-	TROCR	= 0x0700,	/* R-Car Gen3 only */
+	TROCR	= 0x0700,	/* R-Car Gen3 and RZ/G2L only */
 	CEFCR	= 0x0740,
 	FRECR	= 0x0748,
 	TSFRCR	= 0x0750,

diff --git a/drivers/net/ethernet/renesas/ravb_main.c

b/drivers/net/ethernet/renesas/ravb_main.c
index 54c4d31a6950..d38fc33a8e93 100644

--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c

@@ -2114,6 +2114,8 @@ static const struct ravb_hw_info rgeth_hw_info = {
 	.set_feature = ravb_set_features_rgeth,
 	.dmac_init = ravb_dmac_init_rgeth,
 	.emac_init = ravb_rgeth_emac_init,
+	.aligned_tx = 1,
+	.tx_counters = 1,

   Mhm, I don't see a connection between those 2 (other than they're both
for RX). And anyway, this prolly should be a part of the previous patch...

There was a discussion to make smaller patches. If there is no objection, on
the next revision I will add this as part of previous patch.

Regards,
Biju