Re: [RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and... | netdev

[RFC/PATCH 00/18] Add Gigabit Ethernet driver support · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
[RFC/PATCH 01/18] ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 01/18] ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" · Sergey Shtylyov <hidden> · 2021-09-27
[RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
RE: [RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 03/18] ravb: Initialize GbEthernet dmac · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 03/18] ravb: Initialize GbEthernet dmac · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 03/18] ravb: Initialize GbEthernet dmac · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 03/18] ravb: Initialize GbEthernet dmac · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 03/18] ravb: Initialize GbEthernet dmac · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
RE: [RFC/PATCH 03/18] ravb: Initialize GbEthernet dmac · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
RE: [RFC/PATCH 03/18] ravb: Initialize GbEthernet dmac · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 04/18] ravb: Enable aligned_tx and tx_counters for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 04/18] ravb: Enable aligned_tx and tx_counters for RZ/G2L · Sergey Shtylyov <hidden> · 2021-09-23
Re: [RFC/PATCH 04/18] ravb: Enable aligned_tx and tx_counters for RZ/G2L · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 04/18] ravb: Enable aligned_tx and tx_counters for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
RE: [RFC/PATCH 04/18] ravb: Enable aligned_tx and tx_counters for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 05/18] ravb: Exclude gPTP feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 05/18] ravb: Exclude gPTP feature support for RZ/G2L · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 05/18] ravb: Exclude gPTP feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 05/18] ravb: Exclude gPTP feature support for RZ/G2L · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 05/18] ravb: Exclude gPTP feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
RE: [RFC/PATCH 05/18] ravb: Exclude gPTP feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 06/18] ravb: Add multi_tsrq to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 06/18] ravb: Add multi_tsrq to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 06/18] ravb: Add multi_tsrq to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-24
RE: [RFC/PATCH 06/18] ravb: Add multi_tsrq to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 07/18] ravb: Add magic_pkt to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 07/18] ravb: Add magic_pkt to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-23
RE: [RFC/PATCH 07/18] ravb: Add magic_pkt to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-24
RE: [RFC/PATCH 07/18] ravb: Add magic_pkt to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 08/18] ravb: Add mii_rgmii_selection to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 08/18] ravb: Add mii_rgmii_selection to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-24
RE: [RFC/PATCH 08/18] ravb: Add mii_rgmii_selection to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-25
RE: [RFC/PATCH 08/18] ravb: Add mii_rgmii_selection to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 09/18] ravb: Add half_duplex to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 09/18] ravb: Add half_duplex to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-24
RE: [RFC/PATCH 09/18] ravb: Add half_duplex to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-25
RE: [RFC/PATCH 09/18] ravb: Add half_duplex to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 10/18] ravb: Initialize GbEthernet E-MAC · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 10/18] ravb: Initialize GbEthernet E-MAC · Sergey Shtylyov <hidden> · 2021-09-24
RE: [RFC/PATCH 10/18] ravb: Initialize GbEthernet E-MAC · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-25
[RFC/PATCH 11/18] ravb: Add rx_2k_buffers to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 11/18] ravb: Add rx_2k_buffers to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-24
RE: [RFC/PATCH 11/18] ravb: Add rx_2k_buffers to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
[RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-25
RE: [RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
RE: [RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-26
Re: [RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-26
Re: [RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Sergei Shtylyov <hidden> · 2021-09-26
RE: [RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-27
RE: [RFC/PATCH 12/18] ravb: Add timestamp to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-27
[RFC/PATCH 13/18] ravb: Add rx_ring_free function support for GbEthernet · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 13/18] ravb: Add rx_ring_free function support for GbEthernet · Sergey Shtylyov <hidden> · 2021-09-27
RE: [RFC/PATCH 13/18] ravb: Add rx_ring_free function support for GbEthernet · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-28
[RFC/PATCH 14/18] ravb: Add rx_ring_format function for GbEthernet · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 14/18] ravb: Add rx_ring_format function for GbEthernet · Sergey Shtylyov <hidden> · 2021-09-27
RE: [RFC/PATCH 14/18] ravb: Add rx_ring_format function for GbEthernet · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-29
[RFC/PATCH 15/18] ravb: Add rx_alloc helper function for GbEthernet · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
[RFC/PATCH 16/18] ravb: Add Packet receive function for Gigabit Ethernet · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 16/18] ravb: Add Packet receive function for Gigabit Ethernet · Sergey Shtylyov <hidden> · 2021-10-01
RE: [RFC/PATCH 16/18] ravb: Add Packet receive function for Gigabit Ethernet · Biju Das <biju.das.jz@bp.renesas.com> · 2021-10-04
[RFC/PATCH 17/18] ravb: Add carrier_counters to struct ravb_hw_info · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 17/18] ravb: Add carrier_counters to struct ravb_hw_info · Sergey Shtylyov <hidden> · 2021-09-28
[RFC/PATCH 18/18] ravb: Add set_feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-09-23
Re: [RFC/PATCH 18/18] ravb: Add set_feature support for RZ/G2L · Sergey Shtylyov <hidden> · 2021-09-30
RE: [RFC/PATCH 18/18] ravb: Add set_feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-10-01
Re: [RFC/PATCH 18/18] ravb: Add set_feature support for RZ/G2L · Sergey Shtylyov <hidden> · 2021-10-01
RE: [RFC/PATCH 18/18] ravb: Add set_feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-10-01
RE: [RFC/PATCH 18/18] ravb: Add set_feature support for RZ/G2L · Biju Das <biju.das.jz@bp.renesas.com> · 2021-10-01
Re: [RFC/PATCH 00/18] Add Gigabit Ethernet driver support · Sergey Shtylyov <hidden> · 2021-09-23
Re: [RFC/PATCH 00/18] Add Gigabit Ethernet driver support · Sergey Shtylyov <hidden> · 2021-09-23
Re: [RFC/PATCH 00/18] Add Gigabit Ethernet driver support · Jakub Kicinski <kuba@kernel.org> · 2021-09-23
Re: [RFC/PATCH 00/18] Add Gigabit Ethernet driver support · Sergey Shtylyov <hidden> · 2021-09-23

Re: [RFC/PATCH 02/18] ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active"

From: Sergey Shtylyov <hidden>
Date: 2021-09-23 17:57:58
Also in: linux-renesas-soc

On 9/23/21 7:35 PM, Biju Das wrote:

[...]

quoted

Rename the variable "no_ptp_cfg_active" with "no_gptp" with inverted
checks and "ptp_cfg_active" with "ccc_gac".

   That's not exactly rename, no? At least for the 1st case...

This is what we agreed as per last discussion[1]. 

https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210825070154.14336-5-biju.das.jz@bp.renesas.com/

   Sorry, I've changed my mind about 'no_gpgp' after seeing all the checks. I'd like to avoiud the double negations
in those checks -- this should make the code more clear. My 1st idea (just 'gp[tp') turned out to be more practical,
sorry about this going back-and-forth. :-<

[...]

MBR, Sergey

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help