Hi Sergei,

Subject: Re: [RFC/PATCH 11/18] ravb: Add rx_2k_buffers to struct
ravb_hw_info

On 9/23/21 5:08 PM, Biju Das wrote:

quoted

R-Car AVB-DMAC has Maximum 2K size on RZ buffer.
We need to Allow for changing the MTU within the limit of the maximum
size of a descriptor (2048 bytes).

Add a rx_2k_buffers hw feature bit to struct ravb_hw_info to add this
constraint only for R-Car.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/net/ethernet/renesas/ravb.h      | 1 +
 drivers/net/ethernet/renesas/ravb_main.c | 8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb.h

b/drivers/net/ethernet/renesas/ravb.h
index 7532cb51d7b8..ab4909244276 100644

--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h

@@ -1033,6 +1033,7 @@ struct ravb_hw_info {
 	unsigned magic_pkt:1;		/* E-MAC supports magic packet

detection */

quoted

 	unsigned mii_rgmii_selection:1;	/* E-MAC supports mii/rgmii

selection */

quoted

 	unsigned half_duplex:1;		/* E-MAC supports half duplex mode */
+	unsigned rx_2k_buffers:1;	/* AVB-DMAC has Max 2K buf size on RX

*/

   It seems more flexible to specify the buffer size, not just a bit like
this...

Agreed, will use rx_max_buf_size variable on the next version.

Regards,
Biju