Thread (25 messages) 25 messages, 7 authors, 2019-09-19

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2019-09-19 11:36:44

On Thu, Sep 19, 2019 at 01:18:16PM +0200, David Miller wrote:
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Thu, 19 Sep 2019 13:01:25 +0200
quoted
If the packet data of all the fraglist GRO skbs are backed by a
page fragment then we could just do the same by iterating with
skb_walk_frags(). I'm not a driver expert and might be misstaken,
but it looks like that could be done with existing hardware that
supports segmentation offload.
Having to add frag list as well as page frag iterating in a driver is
quite a bit of logic, and added complexity.

If the frag list SKBs are indeed backed by a page, you could just as
easily coalesce everything into the page frag array of the first SKB.
That is true indeed. Fraglist GRO is more optimized to the case
where we still need the skb arround the packet data. I.e. if it 
can't be offloaded.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help