Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO
From: David Miller <davem@davemloft.net>
Date: 2019-09-19 11:18:25
From: David Miller <davem@davemloft.net>
Date: 2019-09-19 11:18:25
From: Steffen Klassert <steffen.klassert@secunet.com> Date: Thu, 19 Sep 2019 13:01:25 +0200
If the packet data of all the fraglist GRO skbs are backed by a page fragment then we could just do the same by iterating with skb_walk_frags(). I'm not a driver expert and might be misstaken, but it looks like that could be done with existing hardware that supports segmentation offload.
Having to add frag list as well as page frag iterating in a driver is quite a bit of logic, and added complexity. If the frag list SKBs are indeed backed by a page, you could just as easily coalesce everything into the page frag array of the first SKB.