Thread (64 messages) flat view 64 messages, 10 authors, 2016-12-11

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: 2016-12-05 22:37:23
Also in: lkml

Hi Pavel,

On 05.12.2016 23:02, Pavel Machek wrote:
we need spin_lock_bh at minimum, as we are locking user context
against timer.

Best regards,
									Pavel
I was referring to stmmac_tx_clean() which AFAICS is only called from softirq context,
(one time in the timer handler and one time in napi poll handler) so a spin_lock() should
be sufficient. I cant see how this is called from userspace. If it were, a spin_lock_bh() had
to be used, of course.

Regards,
Lino 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help