Re: [PATCH] stmmac ethernet: remove cut & paste code
From: Joe Perches <joe@perches.com>
Date: 2016-11-24 20:05:33
Also in:
lkml
On Thu, 2016-11-24 at 12:05 +0100, Pavel Machek wrote:
Remove duplicate code from _tx routines.
trivia:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[]
quoted hunk ↗ jump to hunk
@@ -1960,6 +1960,38 @@ static void stmmac_tso_allocator(struct stmmac_priv *priv, unsigned int des, } } +static void stmmac_xmit_common(struct sk_buff *skb, struct net_device *dev, int nfrags, struct dma_desc *desc) +{ + struct stmmac_priv *priv = netdev_priv(dev); + + if (unlikely(stmmac_tx_avail(priv) <= (MAX_SKB_FRAGS + 1))) { + if (netif_msg_hw(priv)) + pr_debug("%s: stop transmitted packets\n", __func__);
netif_dbg(priv, hw, dev, "%s: stop transmitted packets\n", __func__);