Re: [PATCH] stmmac: simplify flag assignment
From: David Miller <davem@davemloft.net>
Date: 2016-12-01 20:23:06
Also in:
lkml
From: Pavel Machek <redacted> Date: Wed, 30 Nov 2016 12:44:31 +0100
quoted hunk ↗ jump to hunk
Simplify flag assignment. Signed-off-by: Pavel Machek <redacted>diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index ed20668..0b706a7 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c@@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev, features &= ~NETIF_F_CSUM_MASK; /* Disable tso if asked by ethtool */ - if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) { - if (features & NETIF_F_TSO) - priv->tso = true; - else - priv->tso = false; - } + if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) + priv->tso = !!(features & NETIF_F_TSO);
Pavel, this really seems arbitrary. Whilst I really appreciate you're looking into this driver a bit because of some issues you are trying to resolve, I'd like to ask that you not start bombarding me with nit-pick cleanups here and there and instead concentrate on the real bug or issue. Thanks in advance.