RE: [PATCH] net/udp: do not touch skb->peeked unless really needed
From: David Laight <hidden>
Date: 2016-12-07 17:09:49
From: Paolo Abeni
Sent: 06 December 2016 17:08
...
quoted hunk ↗ jump to hunk
@@ -79,6 +82,9 @@ struct udp_sock { int (*gro_complete)(struct sock *sk, struct sk_buff *skb, int nhoff); + + /* since we are prone to drops, avoid dirtying any sk cacheline */ + atomic_t drops ____cacheline_aligned_in_smp; };
Isn't that likely to create a large hole on systems with large cache lines. (Same as any other use of ____cacheline_aligned_in_smp.) David